[pisa-src] Re: r2957 - in trunk: community-operator/server/protos.h pairing/util/protos.h

  • From: Diego Biurrun <diego@xxxxxxxxxx>
  • To: pisa-src@xxxxxxxxxxxxx
  • Date: Tue, 27 Mar 2012 15:49:00 +0200

On Sun, Mar 25, 2012 at 10:54:26PM +0200, Christoph Viethen wrote:
> 
> Log:
> Fix autobuilder's complaint about pairing/util/protos.h file.
> 
> Also fix #define'd naming of two protos.h files.
> 
> --- trunk/community-operator/server/protos.h  Fri Mar 23 19:17:36 2012        
> (r2956)
> +++ trunk/community-operator/server/protos.h  Sun Mar 25 22:54:22 2012        
> (r2957)
> @@ -6,8 +6,8 @@
>  
> -#ifndef _PROTOS_H
> -#define _PROTOS_H 1
> +#ifndef PISA_CO_SERVER_PROTOS_H
> +#define PISA_CO_SERVER_PROTOS_H 1

This is not the filename, which we use as multiple inclusion guard and
we don't define these to 1.

You also did not comment the matching #endif.

> --- trunk/pairing/util/protos.h       Fri Mar 23 19:17:36 2012        (r2956)
> +++ trunk/pairing/util/protos.h       Sun Mar 25 22:54:22 2012        (r2957)
> @@ -9,8 +9,10 @@
>  
> -#ifndef _PROTOS_H
> -#define _PROTOS_H 1
> +#ifndef PISA_PAIRUTIL_PROTOS_H
> +#define PISA_PAIRUTIL_PROTOS_H 1

see above

Diego
-- 
This is the pisa developer mailing list. Please also subscribe to the main pisa 
list at:
//www.freelists.org/list/pisa

Other related posts: