[openbeosstorage] Re: session module


> > Yes, I see no reason not to do otherwise (I do like BeOS' cdda
> > filesystem :-).
> > 
> > > Then it seems the flags for session 1 are not set correctly. They
> > > should indicate a data session.
> > 
> > Oops, I'll fix that, thanks.
> 
> Already done. I had to, when fixing the error above. :-)

Thanks :-)

> 
> > > Even more things to discover: Our implementation implicitly
> > > assumes,
> > > that the (logical) block size of the device is also that of the
> > > session
> > > and the partitions. Shall the session and the partition modules
> > > return
> > > their block size? I mean, there is a field in both of the
> > > structures,
> > > so that wouldn't be a problem.
> > 
> > Hmmm, they could... Are they likely to ever differ, thoguh?
> 
> In the example above they do. Session 0 has a block size of 512, while
> 1 has 2048.

Oops, missed that, too :-) Seems like a reasonable argument for letting 
FSes dictate block sizes when appropriate.

-Tyler

Other related posts: