[openbeosstorage] Re: ddm questions

On 2003-10-24 at 19:57:25 [+0200], you wrote:
> On 2003-10-24 at 04:39:41 [-0700], you wrote:
[...]
> > - maybe a user_strdup()
> > would be better instead of user_strcpy(). However, the best way to do
> > this is to call strlen() in userland and pass the parameter length as
> > an extra argument, and then use malloc() and user_memcpy() to copy the
> > data - operating with userland strings is not really very safe (because
> > they don't need to be null-terminated)
> 
> That would be fine with me (adding a buffer length parameter). Ingo?

Fine with me too.

[...]
> > > + Do we have a limit on the length of those parameter strings? I'm
> > > currently assuming no.
> > 
> > I don't think there is a limit. However, to be more robust, we should
> > introduce one, 32K or 64K.
> 
> Take your pick. :-)

I'd say 32 KB should suffice.

CU, Ingo

Other related posts: