[openbeosstorage] Re: Open-beos-cvs digest, Vol 1 #1359 - 5 msgs

Tyler wrote:
> + Added licenses 
> ...
> +//------------------------------------------------------------------
> ------------
> +//   Copyright (c) 2001-2002, OpenBeOS
> +//

Although you've obviously realized it yourself during the update, we 
already have 2003 :-)
Anyway, do you really think we need that big fat license at the top of 
every file=3F I really prefer the short "distrubuted under the terms of 
the OpenBeOS license" phrase more which we have used for everything 
else in the kernel to date.

> -//#define TRACE(x)
> -#define TRACE(x) dprintf x
> +#define TRACE(x)
> +//#define TRACE(x) dprintf x

I would suggest you to "fix" the silent TRACE macro to:
#define TRACE(x) ;

If you don't have this semicolon in there, you can easily produce code 
that behaves different with both marco definitions, for example:

if (xyz)
        TRACE(abc)

a =3D b;

Of course this would require you to don't use the ";" at the end of the 
line which might be highly unlikely, but it still could happen (and the 
compiler wouldn't complain at all). Those bugs are easy to make and 
often hard to track down.

Adios...
   Axel.

Other related posts: