[openbeosstorage] Re: BSymLink tests and check_*_name() added

> > > Since I guess, I will finish the BSymLink implementation tomorrow, I'm
> I guess, I was too optimistic. I mean, I kind of finished it indeed, but
> it was by far not as easy as it seemed to be.
> 
> Apparently there is no (publicly available) functionality to read a
> symlink's contents having only its file descriptor at hand.
> As a work-around, now a BSymLink owns a BEntry that is set/unset whenever
> the SetTo()/Unset() is invoked on the BSymLink object. Since BSymLink
> originally  didn't implement these methods, but let BNode do the work
> (BTW, some BNode::SetTo() version were unimplemented, thus I filled them
> in), the linking of the R5 test app broke.
> Well, finally, after getting familiar with Jam, I was able to get the two
> sets of tests compiled with their respective headers and now everything
> works again. :-)

I was looking through that Jamfile stuff shortly after you checked it in
and wondered what that was all about. :-) That makes sense, though.

> > > Or, Tyler, do you want me rather to help you with BEntry or BPath, so
> > > that we get the core classes done faster?
> > Actually, yes. Why don't you take over BPath? I'm basically done with 
> > BEntry, but I need to round out the tests for it quite a bit. Plus I'm 
> > finding myself a bit short on free time this quarter.
> Alright, then I start fighting with BPath.
> Afterwards I would like to attack BResources (unless someone objects).
> That is we might want to run a more thorough cleanup iteration on the core
> classes before.

Yes, I would like to get the core classes polished up to the same degree
as all the classes you've worked on so far. Here's what I think remains:

BEntry and BNode both need work on documentation and tests. 

BEntry's implementation is, I believe, basically complete, although testing 
may show some things don't work completely (I still haven't tried cyclic links, 
for instance). 

IIRC, BNode needs a few constructors (probably one line of code each :-), 
and there are a handful of unused, non-virtual functions carried over from 
the R5 implementation that could be removed.

BEntryList is done, but \param and \return listings should be added
to the doxygen.

BStatable needs the doxygen pulled into the source file. I don't recall 
how much testing was done on it (Mike?).

BNodeInfo appears to be mostly done except for a couple of functions,
doxygen, and tests (again, Mike? :-).

I got a little bit of doxygen done in Entry.cpp today, but I'm really strapped
for free time this quarter. Considering my lack of time over the next seven
weeks, I'm fine with you (Ingo) polishing up BEntry, BNode, and BEntryList
if you're interested (actually, go in the opposite order; I'm more familiar with
BEntry right now and might be able to finish up the doxygen before you get 
to it ;-P). If not, I'm happy to work on them as I'm able, but I don't think 
I'll 
get much more than three nights of work in a week. 

What do you think?

-Tyler

Other related posts: