[openbeosstorage] BNode:set_fd() and other things

Hello folks,
(actually this might interest Tyler only)

I noticed, that the BNode::set_fd() implementation doesn't return a
value. I just realized that after I added missing checks for its return
value in BFile. I added a simple `return B_OK'. Otherwise almost all BFile
test would fail.
(Just to prevent, that future changes to set_fd()'s implementation break
BFile: Currently it is assumed, that the supplied file descriptor is not
closed in case set_fd() returns a value != B_OK.)

I wonder, if BDirectory::fDir/fDirFd will be needed at all. At least until
now I see no reason, why the file descriptor used by BDirectory should be
a different one than that of BNode. Perhaps I'm missing something, but
I will see as soon as the test suite is done and the class is implemented.
However, friend classes will use get_fd() anyway.

Just to be sure: StorageKit::FileDescriptor will be the (only) type we'll
use in the SK classes. Correct?
And StorageKit::Dir will disappear and directory file descriptors will be
treated as any other file descriptor. Also correct?

CU, Ingo

Other related posts: