[openbeosstorage] Re: BNodeInfo::GetTrackerIcon()

"Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx> wrote:
> "Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx> wrote:
> > First, the generic MIME type is also defined as a constant, 
> > but it shouldn't be taken for all files. Instead, it should be 
> > differentiated by file type. I.e. it should take "application/x-
> > vnd.Be-directory" 
> > for directories, "application/x-vnd.Be-volume" for volumes, etc.
> BTW if you don't mind I could do these changes, because I need them 
> at 
> another place (BeMail), too. Would that be okay for you?

I've added an updated version of it to BeMail, and I get aware of the 
fact, that you rarely send folders/volumes/symlinks/etc. as an 
attachment.
IOW I didn't need to make these changes. Instead, I now let it search 
for the super types icon if the MIME type itself didn't have any - 
works great.
If you would be very disappointed, I could still make the changes, 
though :)

> Which brings me to suggesting a:
> 
> static status_t BNodeInfo::GetTrackerIcon(const char *fileType, 
> BBitmap 
> *icon, icon_size which = B_LARGE_ICON);
> 
> What do you think?

Bad, it should be:
status_t BMimeType::GetTrackerIcon(BBitmap *icon, icon_size which);

Hope you don't mind me talking to myself :)

Bye,
   Axel.

Other related posts: