[openbeosnetteam] Re: moving ppp to other location

> However, all others PPP sub-modules are PPP specifics: they follow a
separate
> PPP API, aka the core stack don't know nor handle them himself.
> So, they should not be located under
src/add-ons/kernel/network/interfaces/*
> nor src/add-ons/kernel/network/protocols/*, as modules living here are
expected
> to follow the stack core API.
> So, to isolate PPP sub-modules, it make sense to put them under
> src/add-ons/kernel/network/ppp/*.
> And shared code between them should be placed here, in a "shared"
sub-folder.

Oh, then we do not have the problem with the naming. :)
I forgot that it should be kernel/network/interfaces. This means I can call
it kernel/network/interfaces/ppp and the modules are in
kernel/network/ppp/*. Or am I wrong here?

> > You know that there is no direct possibility to say open_module(const
> > char *path)?
> > You need to know the module name, not its file name to open it.
>
> I guess Waldemar was talking of module name, not module path in this case.
>
> > std_ops() are kernel private - you just don't touch them.
>
> Agreed.

Good.
This weekend the library will be feature-freezed. I only have to finish
authenticators support.
After that I will start the ppp interface module and change the netstack
interface API to support the control() hook.

> > > Well, some will like it, others will not. ;)
> > > So, it will be called
> > > "network/ppp/pppoe/v1"? Did I understand you correctly?
> >
> > That sounds good.
>
> Thanks!
>
> Hence a future PPPoE module source code location, under
> src/add-ons/kernel/network/ppp/pppoe/*, using the PPP shared code
> in src/add-ons/kernel/network/ppp/shared/*.
> I hope having made that layout clear!?
> ;-)

Perfectly clear, thanks! :)

Waldemar

Other related posts: