> All the input functions are declared void, or are supposed to be! I
> made the
> change a while back so we actually return void, but if you're
> bothered then
> do something else, but don't change the basic behaviour of the server
> so it
> doesn't work!
If they are declared void, why is there a return statement? That makes
no sense. Further, it's an error. Should I just move the statement
above, and then do a void return?
> The pr_input definition is in include/sys/protosw.h, where it's been
> for a
> while now, and yes, it's a void function. We return the function as
> it's the
> end of that part of the routine...
This is an error, and this is what you are doing. Hence, I commented
out the 3.
void foo() {
return 3;
}
this too:
void foo() {
return foo2();
}
This is not an error:
void foo() {
foo2();
}
Should we restructure it like this?
> How do you expect the server to work with that function commented
> out??? No
> IP packets (and you've done it other places as well) will EVER be
> forwarded
> to where it's supposed to go and what's more the mbuf will never be
> freed,
> so you'll use memory like it's water. Are you sude you got it running
> before
> you committed these changes?
OK, uncomment it. I got it *compiling*, as I made non-substantive
changes to make it compile. I didn't realize that was an important
function call, the problem was a valued return in a void function. If
you want, fix it, as I have to go now.
-Nathan
--
Fortune Cookie Says:
If only one could get that wonderful feeling of accomplishment without
having to accomplish anything.