[openbeosnetteam] Re: Why does the make environment automatically do a buildclean?

All the input functions are declared void, or are supposed to be! I made the
change a while back so we actually return void, but if you're bothered then
do something else, but don't change the basic behaviour of the server so it
doesn't work!

The pr_input definition is in include/sys/protosw.h, where it's been for a
while now, and yes, it's a void function. We return the function as it's the
end of that part of the routine...

How do you expect the server to work with that function commented out??? No
IP packets (and you've done it other places as well) will EVER be forwarded
to where it's supposed to go and what's more the mbuf will never be freed,
so you'll use memory like it's water. Are you sude you got it running before
you committed these changes?

david

----- Original Message -----
From: "Nathan Whitehorn" <nathan.whitehorn@xxxxxxxxxxx>
To: <openbeosnetteam@xxxxxxxxxxxxx>
Sent: Sunday, May 19, 2002 3:29 AM
Subject: [openbeosnetteam] Re: Why does the make environment automatically
do a buildclean?


> > RCS file: /cvsroot/open-beos/net_kit/source/server/ipv4/ipv4.c,v
> > retrieving revision 1.42
> > retrieving revision 1.43
> > diff -u -d -r1.42 -r1.43
> > --- ipv4.c 13 May 2002 08:37:34 -0000 1.42
> > +++ ipv4.c 18 May 2002 21:19:00 -0000 1.43
> > @@ -777,7 +777,7 @@
> >
> >   ipstat.ips_delivered++;
> >   if (proto[ip->ip_p] && proto[ip->ip_p]->pr_input) {
> > - return proto[ip->ip_p]->pr_input(m, hlen);
> > + return; /* proto[ip->ip_p]->pr_input(m, hlen);*/
> >   } else {
> >   printf("proto[%d] = %p\n", ip->ip_p, proto[ip->ip_p]);
> >   goto bad;
> >
> > Unless I'm mistaken (possible) then failing to call the next levels
> > input
> > function will stop the packet in it's tracks as dead as a dodo. not
> > qhat we
> > want! After all, that's why we waste the effort finding out if the
> > input
> > function is valid.
> >
> > You've done this in a few places. :(
>
> You will notice that the function is declared void. Explain to me why
> you are returning a value from a function that is declared void?
> -Nathan
>
> --
> Fortune Cookie Says:
>
> Your lucky number is 3552664958674928.  Watch for it everywhere.
>
>
>

Other related posts: