[open-beos-printing] Re: printkit source related reorganization
- From: julun <host.haiku@xxxxxx>
- To: open-beos-printing@xxxxxxxxxxxxx
- Date: Mon, 21 Jul 2008 21:25:38 +0200
Hi Michael,
Michael Pfeiffer schrieb:
Hi Karsten!
Am 21.07.2008 um 16:03 schrieb Julun:
...snipped...
What do you think?
Please do as you have proposed. Maybe you can also merge the various
*Utils* header and source files into a single header and source file; or
into UI and non-UI related files?
I had not time to check dependencies between the source files. When you
do the refactoring please try to break existing cyclic dependencies and
avoid new ones :-)
If it it makes sense you could also try to separate between
functionality that concerns printer drivers, printer transport add-ons,
print_server, the preferences application and common printing related
things.
Moving libprint into src/libs/print sounds good, as long as it does not
have any dependencies to internal API. This way printer driver
developers could use it and would not depend on the internal API that
could change in the future. Or maybe my assumption is wrong that
src/libs is a place for 3rd party libraries only.
@Jovan: Please let us know if you have code that needs to be committed
before the refactoring can take place.
thank you for your fast response :) Currently I'm trying to get the files
into it's new place and adjust the build accordingly. I will look into
merging and dependency checking afterwards. When it comes to libprint, i
could not found anything obvious that depends on internal API.
I will wait with committing the changes until Jovan responds.
Regards,
Karsten
- References:
- [open-beos-printing] printkit source related reorganization
- From: Julun
- [open-beos-printing] Re: printkit source related reorganization
- From: Michael Pfeiffer
Other related posts:
- » [open-beos-printing] printkit source related reorganization
- » [open-beos-printing] Re: printkit source related reorganization
- » [open-beos-printing] Re: printkit source related reorganization
- » [open-beos-printing] Re: printkit source related reorganization
- » [open-beos-printing] Re: printkit source related reorganization
- » [open-beos-printing] Re: printkit source related reorganization
- » [open-beos-printing] Re: printkit source related reorganization
- » [open-beos-printing] Re: printkit source related reorganization
- » [open-beos-printing] Re: printkit source related reorganization
- » [open-beos-printing] Re: printkit source related reorganization
- » [open-beos-printing] Re: printkit source related reorganization
- » [open-beos-printing] Re: printkit source related reorganization
- » [open-beos-printing] Re: printkit source related reorganization
- » [open-beos-printing] Re: printkit source related reorganization
- » [open-beos-printing] Re: printkit source related reorganization
Hi Karsten! Am 21.07.2008 um 16:03 schrieb Julun: ...snipped...
What do you think?
Please do as you have proposed. Maybe you can also merge the various *Utils* header and source files into a single header and source file; or into UI and non-UI related files?
I had not time to check dependencies between the source files. When you do the refactoring please try to break existing cyclic dependencies and avoid new ones :-) If it it makes sense you could also try to separate between functionality that concerns printer drivers, printer transport add-ons, print_server, the preferences application and common printing related things.
Moving libprint into src/libs/print sounds good, as long as it does not have any dependencies to internal API. This way printer driver developers could use it and would not depend on the internal API that could change in the future. Or maybe my assumption is wrong that src/libs is a place for 3rd party libraries only.
@Jovan: Please let us know if you have code that needs to be committed before the refactoring can take place.
- [open-beos-printing] printkit source related reorganization
- From: Julun
- [open-beos-printing] Re: printkit source related reorganization
- From: Michael Pfeiffer