[nanomsg] Re: Status
- From: Dirkjan Ochtman <dirkjan@xxxxxxxxxx>
- To: nanomsg <nanomsg@xxxxxxxxxxxxx>
- Date: Fri, 28 Feb 2014 14:18:44 +0100
On Fri, Feb 28, 2014 at 2:05 PM, Paul Colomiets <paul@xxxxxxxxxxxxxx> wrote:
> For my pull requests:
>
> #215 is simple and safe to apply
+1 from me.
> #199 should fix hangup on windows, so it's pretty important
Should... Have you tested it? Do you have a Windows box to test stuff on?
> #200 will break bindings so we should think twice, but from the other side,
> earlier we'll make breaking changes is better.
I think we should take it. Maybe it would be nice to expand the commit
message a little bit with a short description of what you've added and
why it's useful?
> So should I use my permissions, and just apply them now?
Sounds good to me.
Cheers,
Dirkjan
Other related posts:
