[kismac] Re: gpsd and kismac - bug?

I've already patched this one - and yes, it is a bug in gpsd.  Here's the
diff patch including a fix for a serious error in 
the speed output of gpsd (patch for gpsd 2.31):

6:12 [~/src/gpsd-2.31] robin> diff -u gpsd-orig.c gpsd.c
--- gpsd-orig.c 2006-02-22 13:26:00.000000000 +1030
+++ gpsd.c      2006-02-22 13:26:03.000000000 +1030
@@ -864,7 +864,7 @@
            break;
        case 'V':
            if (assign_channel(whoami) && have_fix(whoami->device) &&
isnan(whoami->device->gpsdata.fix.track)
==0)
-               (void)snprintf(phrase, sizeof(phrase), ",V=%.3f",
whoami->device->gpsdata.fix.speed / KNOTS_TO_KPH);
+               (void)snprintf(phrase, sizeof(phrase), ",V=%.3f",
whoami->device->gpsdata.fix.speed * MPS_TO_KNOTS);
            else
                (void)strcpy(phrase, ",V=?");
            break;
@@ -1477,7 +1477,9 @@
                } else {
                    buf[buflen] = '\0';
                    gpsd_report(1, "<= client(%d): %s", cfd, buf);
-
+                       // added to prevent timeouts
+                       subscribers[cfd].active = timestamp();
+
 #ifdef RTCM104_SERVICE
                    if (subscribers[cfd].rtcm) {
                        if (handle_dgpsip_request(cfd, buf, buflen) < 0)




Original Message:
-----------------
From: themacuser themacuser@xxxxxxxxx
Date: Mon, 13 Mar 2006 14:57:25 +1030
To: kismac@xxxxxxxxxxxxx
Subject: [kismac] gpsd and kismac - bug?


I have gpsd version 2.31 (the latest), and KisMac r99. Does anyone  
else get KisMac disconnecting from gpsd after a fair while? When I go  
"Reset GPS Subsystem" it reconnects and is fine.

However, I tried with a netcat session to gpsd, and that exhibited  
the same behavior, getting cut off at the same time as KisMac, so I  
think this is a bug in gpsd. We could include some code to attempt a  
reconnection to gpsd if the connection was dropped, and then display  
an error if we can't. I'll work on it.



--------------------------------------------------------------------
mail2web - Check your email from the web at
http://mail2web.com/ .

Other related posts: