[kismac] Re: Patch for ticket #396 (and #399)

  • From: Geoffrey Kruse <gkruse@xxxxxxxxx>
  • To: "kismac@xxxxxxxxxxxxx" <kismac@xxxxxxxxxxxxx>
  • Date: Tue, 28 Dec 2010 18:10:31 -0800

Thanks, I'll get this checked in!

Geoff

On Dec 28, 2010, at 5:59 PM, Chris Carson <cucarson@xxxxxxxxx> wrote:

> Guys,
>
> I encountered the same issue documented by Trac tickets #396 (and #399). 
> Essentially the _date object is accessed via a dictionary, in line 
> WaveNet.mm:1699, but it has already been deallocated.
>
> It appears that this is because it is not retained in line WaveNet.mm:708.
>
> Here's the patch:
>
> --- WaveNet_orig.mm    2010-12-28 15:40:30.000000000 -1000
> +++ WaveNet.mm    2010-12-27 18:34:34.000000000 -1000
> @@ -705,7 +705,7 @@
>                 }
>             }
>
> -            [WaveHelper secureReplace:&_date withObject:[NSDate date]];
> +            [WaveHelper secureReplace:&_date withObject:[[NSDate date] 
> retain]];
>
>             if (cp._lat!=100) {
>                 pV = [BIValuePair new];
>
> After this change to the latest svn checkout (r393), it no longer crashes for 
> me, at least it has been running for over a day whereas before it would crash 
> within a couple hours.
>
> Hope this helps. Couldn't figure out how to post this to the trac ticket 
> system.
>
> Chris
>
>
>
>

Other related posts: