[interfacekit] Re: app kit tests

While it is not strictly necessary for itemSize to be initialized at declaration (it will be set in the immediately following 'if' block or on the first run through the next 'for' loop), it also doesn't hurt anything to initialize it, and one could certainly argue that initializing it to a sane value is best practice.

I have some time to look at this tonight, as well as tomorrow night; is there a particular issue you're seeing with BMessage, or are you simply assuming that it is involved with the tests not running? I will look either way, but more information is always helpful. ;)

Thanks,

e

Stefano Ceccherini wrote: 
Ok, now I'm able to run the BApplication tests, but (as I told DW already in a
private mail, but I think it's better if everyone on the list knows the issue)
they don't work anymore.
I used to be able to run all of them, now I'm blocked at the first test.
The test blocks and doesn't go on.

I haven't been able to do any debugging due to lack of time (I hope to have a
look at the issue in the next days), but I was wondering if there was anyone
else who was working on that stuff.

Another thing:

This change:
http://cvs.sourceforge.net/viewcvs.py/open-beos/current/src/kits/app/Message.cpp?r1=1.19&r2=1.20
suggested that itemSize should've been left uninitialized, but the next commit:

http://cvs.sourceforge.net/viewcvs.py/open-beos/current/src/kits/app/Message.cpp?r1=1.20&r2=1.21

initializes it to 0.

Could this itemSize thing be one of the reasons why our BMessage implementation
isn't working correctly ?

Sorry for bothering.




____________________________________________________________
Libero ADSL: 3 mesi gratis e navighi a 1.2 Mega, senza costi di attivazione.
Abbonati subito su http://www.libero.it






Other related posts: