[interfacekit] Re: PATCH: BView::IsHidden()

Hi Adi,

"Adi Oanca" <adioanca@xxxxxxxxxxxxx> wrote:
> > I've added the missing BView::IsHidden(BView *lookingFrom) method, 
> > and
> > fixed the former BView::IsHidden() method.
> > I also couldn't resist and applied our style guide to those two 
> > methods
> > to let the idea of its existence grow in your mind (slowly but
> > steadily).
> OK

:-)

> > And, I commented one "ToDo:" item in BView::Hide(), too.
> // TODO: You may hide it by relocating with -17000 coord units to the
> left???
> // "I don't think you want to do that" - axeld.
> 
>     Be did that!

I'd doubt that, but even if they did, I don't think it's a good idea to 
do that. You save two app_server commands (to hide/show the view) but 
would make all the other (positioning) stuff much more complicated.
You could do this in the app_server only, but I would never have a 
fixed size offset, always something that makes sure the view is not 
visible no matter how large it is.

> Please let the TODOs at the start of the line! That way they "glow"
> remembering me there is something to be done.

If you insist on it (even if I don't think it make much sense, since 
you need to search for those anyway if you want to look for them). 
BTW there is nice tool written by Alan "voidref" Westbrook that does 
this job automatically (as Eddie add-on):
http://www.bebits.com/app/3052

> > If you'd be okay, I'd happily commit the patch.
> I'm OK.

Okay, consider it done.

Bye,
   Axel.

Other related posts: