[interfacekit] Re: [Open-beos-cvs]CVS: current/headers/os/interface View.h,1.3,1.4

From: "Marcus Overhagen" <ml@xxxxxxxxxxxx>
> Andrew Bachmann <shatty@xxxxxxxxxxxxxxxxxxxxx> wrote:
>
> > -// virtual void _ReservedView2();
> > + virtual void _ReservedView2();

    Yeah OK, but why have you commented out 'removeFromList'. It IS NEEDED!
    Thanks for the above fix! :-)

> It was INTRODUCED BY Adi Oanca in this modification:
>
>
http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/open-beos/current/headers/os/
interface/View.h.diff?r1=1.2&r2=1.3

    Why are you writing "INTRODUCED BY" with capitals? So what if I did a
mistake? I'm not allowed to??

> The count of virtual functions, as well as the order of them, MUST NOT BE
CHANGED!
    OK!
> But you can add/remove (on virtual) private functions as much as you like.
    Now... is that true if I add one before... _ReservedView5() ?

> And I'M NOT HAPPY ABOUT THE NEW Scale() function.
    Why?

> It it's really needed, it SHOULD BE DECLARED AS BEEING "const".
    I'll do that!

> And why are you changing the naming scheme for private functions?
> This new someStupidFunction() look really bad.
>
> And IT IS AGAINST THE STYLE GUIDE!
>
> http://opentracker.sourceforge.net/guidelines.html
>
> | General
> | Make your code not stick out -- make it consistent with the rest of the
code you are contributing to.
> [...]
> | Classes, structs, type names, namespaces and function names start with
uppercase letters and use InterCapsFormatting (no underlines)
> [...]
> | variables start with lowercase letters and use interCapsFormatting.
>
> Really, you need to be MORE CAREFUL when modifying headers.

    Hey hey hey!!! What's with THIS tone!? If you have something to say...
say it nicely! There is no need to yield! If on the above line I said myself
"he's in a bad mood", here I am really upset about the way to talk!
    I DID followed the style guide!!! Look into View.cpp Window.cpp. The
ONLY thing that I did wrong was a SINGLE letter -->s<--omeStupidFunction()
and you make it such a big deal!! I will change that! I'm also programming
Java - that's why I used that name!
    Note that I have changed methods like some_stupid_function() in that of
above - OpenTracker style isn't it?

    PLEASE hold your tone under control, after all you are not my leader,
Erik is. If you want to yield please go to your mail list and do that!


> regards
> Marcus
    See ya!


Adi.

Other related posts: