[interfacekit] Re: [Open-beos-cvs]CVS: current/headers/os/interface View.h,1.3,1.4

Andrew Bachmann <shatty@xxxxxxxxxxxxxxxxxxxxx> wrote:

> -//   virtual void                    _ReservedView2();
> +     virtual void                    _ReservedView2();

Thank you for fixing this bug Andrew.

It was INTRODUCED BY Adi Oanca in this modification:

http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/open-beos/current/headers/os/interface/View.h.diff?r1=1.2&r2=1.3

The count of virtual functions, as well as the order of them, MUST NOT BE 
CHANGED!
But you can add/remove (on virtual) private functions as much as you like.

And I'M NOT HAPPY ABOUT THE NEW Scale() function.

It it's really needed, it SHOULD BE DECLARED AS BEEING "const".

And why are you changing the naming scheme for private functions?
This new someStupidFunction() look really bad.

And IT IS AGAINST THE STYLE GUIDE!

http://opentracker.sourceforge.net/guidelines.html

| General
| Make your code not stick out -- make it consistent with the rest of the code 
you are contributing to.
[...]
| Classes, structs, type names, namespaces and function names start with 
uppercase letters and use InterCapsFormatting (no underlines)
[...]
| variables start with lowercase letters and use interCapsFormatting. 

Really, you need to be MORE CAREFUL when modifying headers.

regards
Marcus


Other related posts: