[interfacekit] Re: Fwd: BAutolock

> > > Even in case of acquire_sem_etc() calls ?
> > 
> > Yes. The B_CAN_INTERRUPT flag is always set for userland semaphores.
> > 
> > > If so, you should better run and fix the opentracker right now :PPP,
> > > since there is EXACTLY one acquire_sem_etc call around which is 
> > > not like this :P
> > 
> > Oh my god :-)
> > 
> 
> Eheheh! :=)
> BTW, I noticed lots of acquire_sem without the check for B_INTERRUPTED also 
> in our app_server.
> We should either "fix" them or switch to blockers (didn't Be, Inc. use 
> benaphores for the real app_server?)

As long as a thread isn't resumed or suspended by resume_thread(), 
suspend_thread()
or is send a signal, a semaphore doesn't return B_INTERRUPTED, so it's save to 
skip that 
check (at least that's what I think).

> And also in the BAutoLock code.
> And also in the BDirectWindow code I sent to Marcus (Marcus? Still around ?).
Yes, you can checkin that code if you want. But the reverse engineered 
commuication
headers should better be renamed to something like R5_Session.h and put into the
headers/private/interface directory.

Regards
Marcus

Other related posts: