[interfacekit] Re: BScrollView

"Marc Flerackers" <mflerackers@xxxxxxxxxx> wrote:
> I implemented it, and it works, except for a few TODO's, for the
> applications I tried with it. I't just that I haven't been committing 
> code
> for a while now, as no-one else is working on it anyway. As far as I 
> know, I
> wrote all R5 controls, together with Jack Burton. The last ones I did 
> where
> those related to replicants, BDragger and BShelf. If needed I'll 
> commit
> them, but we can't use them yet anyway without app_server.

Please submit all the code you have to prevent duplication of work.

Anyway, I am quite glad that I implemented it, because your 
implementation is very incomplete and partially wrong. By a brief 
comparison:
- the border style is ignored
- the de-archiving mechanism is broken
- SetBorderHighlighted() does not do what the BeBook says but does it 
less efficiently.
- does not care about B_DOCUMENT_WINDOW_LOOK
- SetBorder() is broken
- scroll bar placing is wrong in most situations
- FrameResized() doesn't properly update the border
- GetPreferredSize() is broken
- the CalcFrame() method does not always return the correct values

And that does not include your ToDo-items. In your defense, I must say 
that some of these points (related to borders and positioning) are also 
true for the R5 version.
I hope that the other controls you've written are developed and tested 
more carefully than this one.

Bye,
   Axel.

Other related posts: