[interfacekit] Re: BBlockCache bug

On 2003-09-07 at 05:56:34 [+0200], Jeremy Rand wrote:
> Sorry to reply to my own email but don't forget to uncomment
> BlockCache.cpp from current/src/kits/support/support.src.  If you don't
> do that, you will not build BBlockCache into libopenbeos.so.
> 
> > So, I have the tests done now.  You can find them here:
> > 
> > http://www.magma.ca/~jrand/BBlockCacheTests.zip
> > 
> > I don't have CVS access so if someone can volunteer to check this in,
> > I
> > would appreciate it.

Done. Thanks for your work.

> > However, there is a minor issue.  Marcus has checked in a linked list
> > implementation which looks very good and much better than the one
> > which
> > was there before.  But, there is a deviation in his implementation
> > from
> > Be's.
[...]
> > Both implementations pass the tests with very similar performance.
> > Either is fine and I try to be as "egoless" as possible about these
> > things.  Truth be known, Marcus' implementation does have some great
> > debugging features like setting and checking magic numbers in it
> > which
> > we should probably hold on to.
> > 
> > So, I am looking for someone to decide what should get checked in and
> > then do it for me.  Thanks!

I checked in your adjusted version of Marcus' implementation. If they, as 
you write, perform equally well, then the debugging feature in Marcus' 
version makes it objectively better.

CU, Ingo

Other related posts: