[interfacekit] Re: A patch for BString

Hi,

On 2003-11-13 at 15:08:00 [+0100], burton666@xxxxxxxxx wrote:
> 
> I finally committed Oliver's patch for BString.

Thanks a lot!

> For anyone interested, I suggest you to check the Replace Tests against R5 
> and OBOS implementation, you will be surprised :)
> 
> Ok, these are extreme cases (dunno if we'll ever encounter 1024*50 bytes 
> long strings :), but not bad anyway :))

Well, anyone using Beam will do, since Beam handles mails and their 
attachments via BStrings. Actually, trying to convert "\r\n" to "\n" in 
mails triggered me to do some work on the Replace-methods of BString >:o)

> Good work Oliver!

Thanks >:o), but I have just noticed a small problem (my fault): the 
test-sources StringAppendTest.cpp and StringAssignTest.cpp spit out a 
warning when compiled.

The definition of OUT_OF_MEM_VAL should get moved inside the ifdef, such 
that 

        const int32 OUT_OF_MEM_VAL = 2*1000*1000*1000;
        #ifndef TEST_R5

becomes

        #ifndef TEST_R5
        const int32 OUT_OF_MEM_VAL = 2*1000*1000*1000;

Sorry about that,

        Oliver

Other related posts: