On Tue, Feb 21, 2012 at 05:36:57PM +0200, Xin Gu wrote: > On 20/02/12 22:03, Christof Mroz wrote: > >Review: Needs Fixing > > > >>=== modified file 'lib/core/hostid.c' > >>--- lib/core/hostid.c 2011-11-10 10:35:47 +0000 > >>+++ lib/core/hostid.c 2012-02-20 08:33:22 +0000 > >>@@ -743,11 +744,17 @@ > > > >Probably unrelated: should this handle recursive mkdir()? > >check_and_create_dir() currently does not, as far as I see. > > Regarding to check_and_create_dir(), in libhipl, using it is save, > because the parent directory (user's home folder) should exist. What happens if it does not exist? Diego