[hipl-dev] [Branch ~hipl-core/hipl/trunk] Rev 6290: Rename hip_message_type_name() to hip_get_msg_type_name().

  • From: noreply@xxxxxxxxxxxxx
  • To: HIPL core team <hipl-dev@xxxxxxxxxxxxx>
  • Date: Thu, 23 Feb 2012 10:58:16 -0000

------------------------------------------------------------
revno: 6290
committer: David Martin <david.martin.mailbox@xxxxxxxxxxxxxx>
branch nick: hipl_other_stuff
timestamp: Thu 2012-02-23 11:43:16 +0100
message:
  Rename hip_message_type_name() to hip_get_msg_type_name().
  
  Other message related functions are named hip_get_msg_{type, err, len, ...}
  so this makes sense. Makes it easier to find with autocomplete or grep.
modified:
  hipd/hiprelay.c
  hipd/output.c
  lib/core/builder.c
  lib/core/builder.h
  lib/core/icomm.h


--
lp:hipl
https://code.launchpad.net/~hipl-core/hipl/trunk

Your team HIPL core team is subscribed to branch lp:hipl.
To unsubscribe from this branch go to 
https://code.launchpad.net/~hipl-core/hipl/trunk/+edit-subscription
=== modified file 'hipd/hiprelay.c'
--- hipd/hiprelay.c     2012-01-06 13:19:09 +0000
+++ hipd/hiprelay.c     2012-02-23 10:43:16 +0000
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2010-2011 Aalto University and RWTH Aachen University.
+ * Copyright (c) 2010-2012 Aalto University and RWTH Aachen University.
  *
  * Permission is hereby granted, free of charge, to any person
  * obtaining a copy of this software and associated documentation
@@ -829,7 +829,7 @@
     hip_tlv                      param_type        = 0;
 
     HIP_DEBUG("Msg type :      %s (%d)\n",
-              hip_message_type_name(hip_get_msg_type(ctx->input_msg)),
+              hip_get_msg_type_name(hip_get_msg_type(ctx->input_msg)),
               hip_get_msg_type(ctx->input_msg));
     HIP_DEBUG_IN6ADDR("source address", &ctx->src_addr);
     HIP_DEBUG_IN6ADDR("destination address", &ctx->dst_addr);

=== modified file 'hipd/output.c'
--- hipd/output.c       2012-02-15 17:37:10 +0000
+++ hipd/output.c       2012-02-23 10:43:16 +0000
@@ -1204,7 +1204,7 @@
     HIP_ASSERT(peer_addr != NULL && msg != NULL);
 
     HIP_DEBUG("Sending %s packet\n",
-              hip_message_type_name(hip_get_msg_type(msg)));
+              hip_get_msg_type_name(hip_get_msg_type(msg)));
     HIP_DEBUG_IN6ADDR("hip_send_raw(): local_addr", local_addr);
     HIP_DEBUG_IN6ADDR("hip_send_raw(): peer_addr", peer_addr);
     HIP_DEBUG("Source port=%d, destination port=%d\n", src_port, dst_port);

=== modified file 'lib/core/builder.c'
--- lib/core/builder.c  2012-01-10 17:53:47 +0000
+++ lib/core/builder.c  2012-02-23 10:43:16 +0000
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2010-2011 Aalto University and RWTH Aachen University.
+ * Copyright (c) 2010-2012 Aalto University and RWTH Aachen University.
  *
  * Permission is hereby granted, free of charge, to any person
  * obtaining a copy of this software and associated documentation
@@ -1061,7 +1061,7 @@
  * @param msg_type message type number
  * @return the name of the message type
  */
-const char *hip_message_type_name(const uint8_t msg_type)
+const char *hip_get_msg_type_name(const uint8_t msg_type)
 {
     switch (msg_type) {
     case HIP_I1:            return "HIP_I1";
@@ -1229,7 +1229,7 @@
     HIP_DEBUG_HIT("HIT Sender  ", &msg->hits);
     HIP_DEBUG_HIT("HIT Receiver", &msg->hitr);
     HIP_DEBUG("Msg type :      %s (%d)\n",
-              hip_message_type_name(hip_get_msg_type(msg)),
+              hip_get_msg_type_name(hip_get_msg_type(msg)),
               hip_get_msg_type(msg));
     HIP_DEBUG("Msg length:     %d\n", hip_get_msg_total_len(msg));
     HIP_DEBUG("Msg err:        %d\n", hip_get_msg_err(msg));

=== modified file 'lib/core/builder.h'
--- lib/core/builder.h  2011-04-04 11:46:20 +0000
+++ lib/core/builder.h  2012-02-23 10:43:16 +0000
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2010-2011 Aalto University and RWTH Aachen University.
+ * Copyright (c) 2010-2012 Aalto University and RWTH Aachen University.
  *
  * Permission is hereby granted, free of charge, to any person
  * obtaining a copy of this software and associated documentation
@@ -204,7 +204,7 @@
 void hip_calc_param_len(struct hip_tlv_common *tlv_common,
                         hip_tlv_len contents_size);
 uint16_t hip_get_msg_checksum(struct hip_common *msg);
-const char *hip_message_type_name(const uint8_t);
+const char *hip_get_msg_type_name(const uint8_t);
 struct hip_common *hip_msg_alloc(void);
 void hip_msg_init(struct hip_common *);
 void hip_set_msg_err(struct hip_common *, hip_hdr_err);

=== modified file 'lib/core/icomm.h'
--- lib/core/icomm.h    2011-11-25 17:56:24 +0000
+++ lib/core/icomm.h    2012-02-23 10:43:16 +0000
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2010 Aalto University and RWTH Aachen University.
+ * Copyright (c) 2010, 2012 Aalto University and RWTH Aachen University.
  *
  * Permission is hereby granted, free of charge, to any person
  * obtaining a copy of this software and associated documentation
@@ -50,7 +50,7 @@
  * HIP_MSG_ROOT_MAX.
  *
  * @note Values 1 - 64 overlap the message values and thus cannot be used in
- *       hip_message_type_name().
+ *       hip_get_msg_type_name().
  * @todo Should socket option values 1 - 64 be renumbered starting from 65?
  * @{
  */

Other related posts:

  • » [hipl-dev] [Branch ~hipl-core/hipl/trunk] Rev 6290: Rename hip_message_type_name() to hip_get_msg_type_name(). - noreply