[hipl-commit] [trunk] Rev 4744: midauth: mark/remove unused parameters.
- From: Mircea Gherzan <mircea.gherzan@xxxxxxxxxxxxxx>
- To: hipl-commit@xxxxxxxxxxxxx
- Date: Wed, 9 Jun 2010 17:05:32 +0300
Committer: Mircea Gherzan <mircea.gherzan@xxxxxxxxxxxxxx>
Date: 09/06/2010 at 17:05:32
Revision: 4744
Revision-id: mircea.gherzan@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
Branch nick: trunk
Log:
midauth: mark/remove unused parameters.
Modified:
M firewall/midauth.c
M hipd/output.c
M lib/core/solve.c
M lib/core/solve.h
M modules/update/hipd/update.c
=== modified file 'firewall/midauth.c'
--- firewall/midauth.c 2010-06-01 15:10:53 +0000
+++ firewall/midauth.c 2010-06-09 14:05:14 +0000
@@ -331,7 +331,7 @@
return err;
}
-int midauth_handler_accept(hip_fw_context_t *ctx)
+int midauth_handler_accept(UNUSED hip_fw_context_t *ctx)
{
return NF_ACCEPT;
}
@@ -342,7 +342,7 @@
* @param ctx context of the packet
* @return NF_DROP
*/
-static int midauth_handler_drop(hip_fw_context_t *ctx)
+static int midauth_handler_drop(UNUSED hip_fw_context_t *ctx)
{
return NF_DROP;
}
=== modified file 'hipd/output.c'
--- hipd/output.c 2010-06-09 10:00:07 +0000
+++ hipd/output.c 2010-06-09 14:05:14 +0000
@@ -914,9 +914,7 @@
/** @todo no caching is done for PUZZLE_M parameters. This may be
* a DOS attack vector.
*/
- HIP_IFEL(hip_solve_puzzle_m(ctx->output_msg,
- ctx->input_msg,
- ctx->hadb_entry),
+ HIP_IFEL(hip_solve_puzzle_m(ctx->output_msg, ctx->input_msg),
-1,
"Building of Challenge_Response failed\n");
char *midauth_cert = hip_pisa_get_certificate();
=== modified file 'lib/core/solve.c'
--- lib/core/solve.c 2010-05-26 10:28:47 +0000
+++ lib/core/solve.c 2010-06-09 14:05:14 +0000
@@ -119,16 +119,13 @@
*
* @param out the received R1 message
* @param in an I2 message where the solution will be written
- * @param entry the related host association
* @return zero on success and negative on error
* @see <a
* href="http://tools.ietf.org/id/draft-heer-hip-middle-auth";>Heer et
* al, End-Host Authentication for HIP Middleboxes, Internet draft,
* work in progress, February 2009</a>
*/
-int hip_solve_puzzle_m(struct hip_common *out,
- struct hip_common *in,
- hip_ha_t *entry)
+int hip_solve_puzzle_m(struct hip_common *out, struct hip_common *in)
{
struct hip_challenge_request *pz;
struct hip_puzzle tmp;
=== modified file 'lib/core/solve.h'
--- lib/core/solve.h 2010-05-23 11:33:26 +0000
+++ lib/core/solve.h 2010-06-09 14:05:14 +0000
@@ -18,8 +18,6 @@
#define HIP_PUZZLE_MAX_K 28
uint64_t hip_solve_puzzle(void *puzzle, struct hip_common *hdr, int mode);
-int hip_solve_puzzle_m(struct hip_common *out,
- struct hip_common *in,
- hip_ha_t *entry);
+int hip_solve_puzzle_m(struct hip_common *out, struct hip_common *in);
#endif /* HIP_LIB_CORE_SOLVE_H */
=== modified file 'modules/update/hipd/update.c'
--- modules/update/hipd/update.c 2010-06-08 20:46:25 +0000
+++ modules/update/hipd/update.c 2010-06-09 14:05:14 +0000
@@ -178,7 +178,7 @@
* a DOS attack vector.
*/
if (received_update_packet && type == HIP_UPDATE_ECHO_REQUEST) {
- HIP_IFEL(hip_solve_puzzle_m(update_packet_to_send,
received_update_packet, ha), -1,
+ HIP_IFEL(hip_solve_puzzle_m(update_packet_to_send,
received_update_packet), -1,
"Building of Challenge_Response failed\n");
} else {
HIP_DEBUG("msg is NULL, midauth parameters not included in reply\n");
@@ -188,7 +188,7 @@
* a DOS attack vector.
*/
if (type == HIP_UPDATE_ECHO_RESPONSE) {
- HIP_IFEL(hip_solve_puzzle_m(update_packet_to_send,
received_update_packet, ha), -1,
+ HIP_IFEL(hip_solve_puzzle_m(update_packet_to_send,
received_update_packet), -1,
"Building of Challenge_Response failed\n");
}
#endif
Other related posts:
- » [hipl-commit] [trunk] Rev 4744: midauth: mark/remove unused parameters. - Mircea Gherzan
