[hipl-commit] [trunk] Rev 4250: Remove some pointless and redundant code comments.

  • From: Diego Biurrun <diego@xxxxxxxxxx>
  • To: hipl-commit@xxxxxxxxxxxxx
  • Date: Tue, 13 Apr 2010 14:18:03 +0300

Committer: Diego Biurrun <diego@xxxxxxxxxx>
Date: 13/04/2010 at 14:18:03
Revision: 4250
Revision-id: diego@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
Branch nick: trunk

Log:
  Remove some pointless and redundant code comments.

Modified:
  M  hipd/accessor.c
  M  hipd/output.c

=== modified file 'hipd/accessor.c'
--- hipd/accessor.c     2010-04-09 15:20:38 +0000
+++ hipd/accessor.c     2010-04-13 11:17:51 +0000
@@ -95,15 +95,6 @@
     sock_addr.sin6_addr   = in6addr_loopback;
 
     for (retry = 0; retry < 3; retry++) {
-        /* Switched from hip_sendto() to hip_sendto_user() due to
-         * namespace collision. Both message.h and user.c had functions
-         * hip_sendto(). Introducing a prototype hip_sendto() to user.h
-         * led to compiler errors --> user.c hip_sendto() renamed to
-         * hip_sendto_user().
-         *
-         * Lesson learned: use function prototypes unless functions are
-         * ment only for local (inside the same file where defined) use.
-         * -Lauri 11.07.2008 */
         n = hip_sendto_user(msg, (struct sockaddr *) &sock_addr);
         if (n <= 0) {
             HIP_ERROR("hipconf opptcp failed (round %d)\n", retry);

=== modified file 'hipd/output.c'
--- hipd/output.c       2010-04-13 11:10:38 +0000
+++ hipd/output.c       2010-04-13 11:17:51 +0000
@@ -826,11 +826,6 @@
 
 #ifdef CONFIG_HIP_BLIND
     if (hip_blind_get_status()) {
-        /* Compiler error:
-         * 'nonce' undeclared (first use in this function)
-         * introduced nonce here and initialized it zero.
-         * -Lauri 22.07.2008.
-         */
         uint16_t nonce = 0;
         if ((local_plain_hit =
                  (in6_addr_t *) malloc(sizeof(struct in6_addr))) == NULL) {

Other related posts:

  • » [hipl-commit] [trunk] Rev 4250: Remove some pointless and redundant code comments. - Diego Biurrun