[hipl-commit] [trunk] Rev 3532: Fixed potential bug in hipd/hadb.c. Removed duplicate assignment.

  • From: Tim Just <tim.just@xxxxxxxxxxxxxx>
  • To: hipl-commit@xxxxxxxxxxxxx
  • Date: Thu, 4 Feb 2010 19:22:34 +0200

Committer: Tim Just <tim.just@xxxxxxxxxxxxxx>
Date: Thu Feb 04 18:18:34 2010 +0100
Revision: 3532
Revision-id: tim.just@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
Branch nick: trunk

Log:
  Fixed potential bug in hipd/hadb.c. Removed duplicate assignment.
  
  The assignment 'st = ha->hastate' was made twice. One time before checking 
against NULL -> possible segmentation fault.

Modified:
  M  hipd/hadb.c

=== modified file 'hipd/hadb.c'
--- hipd/hadb.c 2010-02-03 10:10:26 +0000
+++ hipd/hadb.c 2010-02-04 17:18:34 +0000
@@ -244,8 +244,6 @@
 
        HIP_ASSERT(!(ipv6_addr_any(&ha->hit_peer)));
 
-       st = ha->hastate;
-
        HIP_DEBUG("hip_hadb_insert_state() invoked. Inserting a new state to "\
                  "the HIP association hash table.\n");

Other related posts:

  • » [hipl-commit] [trunk] Rev 3532: Fixed potential bug in hipd/hadb.c. Removed duplicate assignment. - Tim Just