[openbeos] Re: trigonometric functions

"Andrew Bachmann" <andrewbachmann@xxxxxxxxxxxxx> wrote:
> I have added some math tests to: src/tests/kernel/libroot/posix/math
> They currently just print a table of the values from our cos/sin
> functions and the values from libbe.  The results are the same as
> Stephan reported. (these functions don't work properly)

Great!
BTW why do you need to define "national" for the libroot.so build but 
not for you test application?

> sin and cos seem to be broken because their subfunctions are
> broken.  This includes at least copysign, and probably drem.
> I may add some tests for these subfunctions specifically since
> they are also supported by libbe.

I guess you mean Be's libroot.so here.

> Two side notes:
> 1. the tests should probably be moved from "kernel" to "system",
> like the src subdirectory was a little while back.

Definitely, I just didn't find the time to do it yet.

> 2. the math test uses get_image_symbol to retrieve the libbe
> function pointers for cos/sin, which is a technique that could
> be useful for other tests as well.

Not too useful most of the time, as these tests are usually thought to 
run under both platforms. Ie. also, and especially, natively under 
Haiku, for example.
It's better to test against known behaviour (like sin^2 + cos^2 == 1 in 
your test).

Bye,
   Axel.

Other related posts: