[openbeos] Re: find_directory quirks

On 2004-02-18 at 00:19:46 [+0100], François Revol wrote:
> find_directory in the cvs is currently broken.
> it implements the C version from the C++ one, which appart from being
> the opposite way of the logic one is broken, as the C one is supposed
> to be in libroot, and the C++ one in libbe:
> 
> [revol@patrick ~/devel]$ nm /system/lib/libroot.so|grep find_directory
> 00053330 T find_directory
> [revol@patrick ~/devel]$ nm /system/lib/libbe.so|grep find_directory
>          U find_directory
> 00151840 T find_directory__F15directory_whichP5BPathbP7BVolume

Though the loss of CVS history covers the tracks, I think this was my bad 
(I wouldn't object, if someone else claimed it though ;-). In my own 
defence I have to say, that the C find_directory() is apparently declared 
in the wrong header -- OK, OK, it's marked _IMPEXP_ROOT. :-)

> I'll need to reimplement it anyway since I need to correct the R5 one
> as they are totally wrong in some situations. So I'll fix the cs as
> well.

Feel free to do that. Don't forget to update the unit tests as well, if 
necessary. :-P

> Besides, the hardcoded values in cvs are bad as well, even the R5 one
> does more stuff.

I wonder, how is it done better?

> Though I'll need ot add a find_directory.c which goes in libroot...
> where should I put that ?

How about src/kernel/libroot/os?

CU, Ingo

Other related posts: