[openbeos] Re: VMware driver/accelerant

On Jan 12, 2007, at 1:40 PM, Axel Dörfler wrote:

  It'd be nice if someone could take the time and include it in Haiku
- this is my first driver ever, someone more experienced should have
a look ;). It's based on Be's sample driver and parts of my code are
inspired by the X.org driver, all this should be MIT-compatible (?).


It seems you don't follow our coding style at all (which would be nice
for eventual further contributions, especially if done for Haiku), but
since that didn't prevent us from accepting other drivers, I don't see
why it should prevent us from accepting it.


 I can change that, shouldn't take long ;)


I don't have VMware around, but I can include it in the repository. Is
your driver only inspired by the X.org drivers, or did you copy code
from it? IOW can I add the missing MIT copyright lines to the code?
There's only one function I copied, but I have to rewrite it in a safer way anyway. The (c) VMware files come with a README that says "The code here may be used/distributed under the terms of the standard XFree86 license", so I guess we can simply add the MIT headers everywhere, keep the (c) VMware in those headers and use (c) Be Inc & Haiku Inc for everything else. I'll do that and upload another tarball. 

--
Eric

Other related posts: