[openbeos] Re: Query menu for Mail

Simon Taylor wrote:

Hi Justin,

Justin O'Dell wrote:

Here is my attempt to satisfy, at least in part, Ticket 1208.  I did not
create a button on the toolbar because I don't think drop down buttons
are implemented yet.

http://dev.haiku-os.org/ticket/1208
http://dev.haiku-os.org/attachment/ticket/1208/20070816%20-%20Ticket%
201208.diff

Would any of you mind taking a look and reviewing my code?


Thanks for this and your previous patch about the preference apps.
There's no real need to post patches here though - just attach them in the relevant bug and add a comment, and everyone who needs to know will automatically receive an email.
As a reply to myself I've done some investigating and found that emails don't get sent when your only change to the bug is adding an attachment. I think that might be expected behaviour though - normally you should describe the attachment with a comment in addition to the short description that you type when adding the attachment.
So in short, what you should have done is add the attachment to the bug (as you did), and then add the description - not creating toolbar button plus instructions for making it do something - as a comment to the bug (instead of this list). That way all the relevant information is sent to the right people and is attached to the bug to which it relates. 

Simon

Other related posts: