[haiku-webkit-commits] r437 - webkit/trunk/WebKit/haiku/WebCoreSupport

  • From: webkit@xxxxxxxxxxxxxxx
  • To: haiku-webkit-commits@xxxxxxxxxxxxx
  • Date: Tue, 20 Apr 2010 13:12:21 +0000

Author: stippi
Date: Tue Apr 20 13:12:20 2010
New Revision: 437
URL: http://mmlr.dyndns.org/changeset/437

Log:
* Access to the request URL in 
FrameLoaderClient::dispatchDidHandleOnloadEvents()
  was unsafe and could crash. Trying to send a mail in GoogleMail will now
  display an error instead of crashing.
* Updated version in UserAgent string.
* Replaced TODO with FIXME, since that is required by WebKit coding style.

Modified:
   webkit/trunk/WebKit/haiku/WebCoreSupport/EditorClientHaiku.cpp
   webkit/trunk/WebKit/haiku/WebCoreSupport/FrameLoaderClientHaiku.cpp

Modified: webkit/trunk/WebKit/haiku/WebCoreSupport/EditorClientHaiku.cpp
==============================================================================
--- webkit/trunk/WebKit/haiku/WebCoreSupport/EditorClientHaiku.cpp      Tue Apr 
20 12:32:26 2010        (r436)
+++ webkit/trunk/WebKit/haiku/WebCoreSupport/EditorClientHaiku.cpp      Tue Apr 
20 13:12:20 2010        (r437)
@@ -432,7 +432,7 @@
         Editor::Command command = 
frame->editor()->command(editorCommandString);
 
 #if 0
-// TODO: This doesn't work correctly, since for example VK_RETURN ends up here 
as
+// FIXME: This doesn't work correctly, since for example VK_RETURN ends up 
here as
 // PlatformKeyboardEvent::RawKeyDown and isTextInsertion() on the other hand, 
so it
 // doesn't get executed. Can't say if the error is somehow that it ends up 
being a
 // RawKeyDown, or if this code (from GTK) is broken.
@@ -752,7 +752,7 @@
 void EditorClientHaiku::imContextPreeditChanged(EditorClient* client)
 {
     const char* newPreedit = 0;
-    // TODO: get pre edit
+    // FIXME: get pre edit
     setPendingPreedit(newPreedit);
 }
 

Modified: webkit/trunk/WebKit/haiku/WebCoreSupport/FrameLoaderClientHaiku.cpp
==============================================================================
--- webkit/trunk/WebKit/haiku/WebCoreSupport/FrameLoaderClientHaiku.cpp Tue Apr 
20 12:32:26 2010        (r436)
+++ webkit/trunk/WebKit/haiku/WebCoreSupport/FrameLoaderClientHaiku.cpp Tue Apr 
20 13:12:20 2010        (r437)
@@ -255,7 +255,6 @@
 void FrameLoaderClientHaiku::dispatchDidHandleOnloadEvents()
 {
     BMessage message(LOAD_ONLOAD_HANDLE);
-    message.AddString("url", 
m_webFrame->Frame()->loader()->documentLoader()->request().url().string());
     dispatchMessage(message);
 }
 
@@ -737,7 +736,7 @@
 WebCore::ResourceError FrameLoaderClientHaiku::cannotShowMIMETypeError(const 
WebCore::ResourceResponse& response)
 {
     notImplemented();
-    // TODO: This can probably be used to automatically close pages that have 
no content,
+    // FIXME: This can probably be used to automatically close pages that have 
no content,
     // but only triggered a download. Since BWebPage is used for initiating a 
BWebDownload,
     // it could remember doing so and then we could ask here if we are the 
main frame,
     // have no content, but did download something -- then we could asked to 
be closed.
@@ -773,7 +772,7 @@
 
 bool FrameLoaderClientHaiku::canShowMIMEType(const String& mimeType) const
 {
-       // TODO: Usually, the mime type will have been detexted. This is 
supposed to work around
+       // FIXME: Usually, the mime type will have been detexted. This is 
supposed to work around
        // downloading some empty files, that can be observed.
        if (!mimeType.length())
            return true;
@@ -859,7 +858,7 @@
 {
     ASSERT(cachedFrame->view());
 
-       // TODO: I guess we would have to restore platform data from the 
cachedFrame here,
+       // FIXME: I guess we would have to restore platform data from the 
cachedFrame here,
        // data associated in savePlatformDataToCachedFrame().
 
     postCommitFrameViewSetup(m_webFrame, cachedFrame->view(), false);
@@ -884,8 +883,8 @@
 
 String FrameLoaderClientHaiku::userAgent(const KURL&)
 {
-       // TODO: Get the app name from the app. Hardcoded WebPositive for now. 
Mentioning "Safari" is needed for some sites like gmail.com.
-    return String("Mozilla/5.0 (compatible; U; InfiNet 0.1; Haiku) 
AppleWebKit/527+ (KHTML, like Gecko) WebPositive/527+ Safari/527+");
+       // FIXME: Get the app name from the app. Hardcoded WebPositive for now. 
Mentioning "Safari" is needed for some sites like gmail.com.
+    return String("Mozilla/5.0 (compatible; U; InfiNet 0.1; Haiku) 
AppleWebKit/528+ (KHTML, like Gecko) WebPositive/528+ Safari/528+");
 }
 
 bool FrameLoaderClientHaiku::canCachePage() const

Other related posts: