[haiku-webkit-commits] r426 - webkit/trunk/WebKit/haiku/API

  • From: webkit@xxxxxxxxxxxxxxx
  • To: haiku-webkit-commits@xxxxxxxxxxxxx
  • Date: Mon, 19 Apr 2010 11:32:21 +0000

Author: stippi
Date: Mon Apr 19 11:32:20 2010
New Revision: 426
URL: http://mmlr.dyndns.org/changeset/426

Log:
Disabling the PageCache fixes the Wikipedia forward/backward crash. I've tracked
this bug a little and in debug mode, it runs into an assert when re-attaching 
the
cached page. Like it wasn't properly detached when it was put into the page
cache. Further investigation is necessary. For now I disable the PageCache, 
since
the stack trace from this crash is the only one I remember besides one crash 
I've
seen in BrowserWindow::_TabChanged().

Also enabled the settings setNeedsSiteSpecificQuirks(), which I presume is
intended for WebBrowsers versus document viewers.

Modified:
   webkit/trunk/WebKit/haiku/API/WebSettingsPrivate.cpp

Modified: webkit/trunk/WebKit/haiku/API/WebSettingsPrivate.cpp
==============================================================================
--- webkit/trunk/WebKit/haiku/API/WebSettingsPrivate.cpp        Sun Apr 18 
23:00:37 2010        (r425)
+++ webkit/trunk/WebKit/haiku/API/WebSettingsPrivate.cpp        Mon Apr 19 
11:32:20 2010        (r426)
@@ -88,7 +88,9 @@
            settings->setLocalStorageEnabled(global->localStorageEnabled);
            settings->setLocalStorageDatabasePath(global->localStoragePath);
            settings->setDefaultTextEncodingName("UTF-8");
-        settings->setUsesPageCache(WebCore::pageCache()->capacity());
+//        settings->setUsesPageCache(WebCore::pageCache()->capacity());
+settings->setUsesPageCache(false);
+        settings->setNeedsSiteSpecificQuirks(true);
 
            // Apply local or global settings
                if (defaultFontSizeSet)

Other related posts:

  • » [haiku-webkit-commits] r426 - webkit/trunk/WebKit/haiku/API - webkit