[haiku-webkit-commits] r406 - webkit/trunk/WebKit/haiku/WebPositive

  • From: webkit@xxxxxxxxxxxxxxx
  • To: haiku-webkit-commits@xxxxxxxxxxxxx
  • Date: Mon, 12 Apr 2010 16:16:41 +0000

Author: stippi
Date: Mon Apr 12 16:16:40 2010
New Revision: 406
URL: http://mmlr.dyndns.org/changeset/406

Log:
strlcpy() takes buffer size, not char count, and will copy buffer size - 1 chars
at max and terminate the buffer.

Modified:
   webkit/trunk/WebKit/haiku/WebPositive/URLInputGroup.cpp

Modified: webkit/trunk/WebKit/haiku/WebPositive/URLInputGroup.cpp
==============================================================================
--- webkit/trunk/WebKit/haiku/WebPositive/URLInputGroup.cpp     Sun Apr 11 
23:21:45 2010        (r405)
+++ webkit/trunk/WebKit/haiku/WebPositive/URLInputGroup.cpp     Mon Apr 12 
16:16:40 2010        (r406)
@@ -323,7 +323,7 @@
                buffer = (char*)malloc(inLength + 1);
 
                if (buffer) {
-                       strlcpy(buffer, inText, inLength);
+                       strlcpy(buffer, inText, inLength + 1);
 
                        for (int32 i = 0; i < inLength; i++) {
                                if (buffer[i] == '\r' || buffer[i] == '\n')

Other related posts:

  • » [haiku-webkit-commits] r406 - webkit/trunk/WebKit/haiku/WebPositive - webkit