[haiku-webkit-commits] Re: r268 - in webkit/trunk: WebCore WebKit/haiku/WebPositive WebKit/haiku/WebPositive/autocompletion

  • From: Stephan Assmus <superstippi@xxxxxx>
  • To: haiku-webkit-commits@xxxxxxxxxxxxx
  • Date: Tue, 02 Mar 2010 19:57:27 +0100

On 2010-03-02 at 19:05:09 [+0100], Ryan Leavengood <leavengood@xxxxxxxxx> 
wrote:
> On Tue, Mar 2, 2010 at 1:40 PM,  <webkit@xxxxxxxxxxxxxxx> wrote:
> > Author: stippi
> >
> > Log:
> > Wired everything and improved the TextControlCompleter behavior a bit with
> > regards to eating the B_RETURN key before we can dispatch in 
> > BrowserWindow. So
> > autocompletion for URLs basically works. What's missing is:
> >
> > * Much better grouping of matches.
> 
> You may want to wait a bit until bookmarks are integrated since you
> will probably want to show them too. Plus maybe an option to search
> Google or whatever like Chrome and Epiphany (assuming we decide on a
> combo address/search bar.) In general though I guess we should sort on
> closest match and then on last accessed date (with more recent
> higher.)

* Bookmarks will show up, since they are included in the history anyway.
* The history is already sorted by access date, with more recent urls higher.

The integration of searching is definitely a nice thing to have.

> > * Fix the delay when the BrowsingHistory is first accessed (lazy loads 
> > itself
> >  from disk just then, ought to do it in the application thread after 
> >  startup,
> >  which probably makes it unnoticable before the user starts typing a URL).
> 
> Sounds reasonable.

Yep, already solved.

> > +++ 
> > webkit/trunk/WebKit/haiku/WebPositive/autocompletion/TextControlCompleter.
> > cpp       Tue Mar  2 18:40:50 2010        (r268)
> > @@ -10,6 +10,7 @@
> >
> >  #include <Looper.h>
> >  #include <TextControl.h>
> > +#include <stdio.h>
> 
> Debugging leftover?

Yes. Though I usually leave these includes there, since I will most likely 
need to put them there again soon after. :-)

Best regards,
-Stephan



Other related posts: