[haiku-webkit-commits] r267 - webkit/trunk/WebKit/haiku/API

  • From: webkit@xxxxxxxxxxxxxxx
  • To: haiku-webkit-commits@xxxxxxxxxxxxx
  • Date: Tue, 02 Mar 2010 18:37:48 +0000

Author: stippi
Date: Tue Mar  2 18:37:48 2010
New Revision: 267
URL: http://mmlr.dyndns.org/changeset/267

Log:
Got some crashes sometimes when closing a page that the looper is not locked
in BView::PushState(). Maybe WebKit still tried to render something right when
the BWebView was going down... dunno.

Modified:
   webkit/trunk/WebKit/haiku/API/WebPage.cpp

Modified: webkit/trunk/WebKit/haiku/API/WebPage.cpp
==============================================================================
--- webkit/trunk/WebKit/haiku/API/WebPage.cpp   Tue Mar  2 12:38:07 2010        
(r266)
+++ webkit/trunk/WebKit/haiku/API/WebPage.cpp   Tue Mar  2 18:37:48 2010        
(r267)
@@ -552,7 +552,10 @@
     // window locked. This cannot deadlock and makes sure
     // the window is not deleting the offscreen view right
     // after we unlock it and before locking the bitmap.
-    offscreenView->LockLooper();
+    if (!offscreenView->LockLooper()) {
+       m_webView->UnlockLooper();
+       return;
+    }
     m_webView->UnlockLooper();
 
     WebCore::GraphicsContext context(offscreenView);

Other related posts:

  • » [haiku-webkit-commits] r267 - webkit/trunk/WebKit/haiku/API - webkit