[haiku-webkit-commits] Re: r266 - in webkit/trunk/WebKit: . haiku/WebPositive/autocompletion

  • From: Stephan Assmus <superstippi@xxxxxx>
  • To: haiku-webkit-commits@xxxxxxxxxxxxx
  • Date: Tue, 02 Mar 2010 19:03:39 +0100

On 2010-03-02 at 18:41:01 [+0100], Ryan Leavengood <leavengood@xxxxxxxxx> 
wrote:
> On Tue, Mar 2, 2010 at 7:38 AM,  <webkit@xxxxxxxxxxxxxxx> wrote:
> > Author: stippi
> >
> > Log:
> > Imported Beam auto completion framework, converted license to MIT (with
> > permission from Oliver) and applied Haiku coding style. The base classes 
> > have
> > been named such that they could become official Haiku API in the future.
> 
> Very cool, this could indeed be useful in various places (such as
> People.) It looks very well designed (MVC, etc.)

Yes, I thought so too when going over the code. Also, it was very easy later 
on when I had to make a few changes in behavior, and that's something I 
always like.

> One small typo:
> 
> > Added: 
> > webkit/trunk/WebKit/haiku/WebPositive/autocompletion/AutoCompleter.h
> > ==========================================================================
> > ====
> [...]
> > +#ifndef AUTO_COMPLETEER_H
> > +#define AUTO_COMPLETEER_H
> 
> Should be AUTO_COMPLETER_H.

Thanks!

Best regards,
-Stephan

Other related posts: