[haiku-webkit-commits] Re: r241 - webkit/trunk/WebCore/platform/haiku

  • From: Ryan Leavengood <leavengood@xxxxxxxxx>
  • To: haiku-webkit-commits@xxxxxxxxxxxxx
  • Date: Sun, 28 Feb 2010 00:12:16 -0500

On Sat, Feb 27, 2010 at 7:00 PM, Stephan Assmus <superstippi@xxxxxx> wrote:
>
> One problem with your solution, is that it runs the timer function in the
> wrong thread. I haven't looked closely enough if that was the only problem,
> or if there was another reason why Andrea rewrote it. That I am using a
> different thread as well is just for improved precision. Otherwise it's
> equivalent to the BMessageRunner version.

Yes I see that I was calling the timer function from the new thread,
which is not how it should work obviously.

I would like to learn from my mistakes, though in this case it may
have just been not understanding how the WebKit timer was supposed to
work. While threading certainly can be difficult, I think I find it
even more difficult trying to deal with a primarily single-threaded
library like WebKit in a multi-threaded environment like Haiku.

-- 
Regards,
Ryan

Other related posts: