[haiku-webkit-commits] Re: r222 - in webkit/trunk/WebCore: . platform/haiku

  • From: Ryan Leavengood <leavengood@xxxxxxxxx>
  • To: haiku-webkit-commits@xxxxxxxxxxxxx
  • Date: Thu, 25 Feb 2010 17:53:50 -0500

On Thu, Feb 25, 2010 at 5:44 PM, Stephan Assmus <superstippi@xxxxxx> wrote:
> Yes, it was copied accidentally from TemporaryLinkStubs. In case you
> wondered, I've read comments on Bugzilla from reviewers which encourage to
> remove copyright cruft when no code is left from the original contributor.
> Like when a file is stubbed out, it doesn't make sense to keep copyright of
> the same file from another port.

Yes I was going to say that but I wasn't sure if you had copied this
file from another port or not...

> Yes. I saw already a lot of these cleanup possibilities. The problem is
> that I have no way to test builds for other platforms. I could imagine to
> set them up, but I believe to get them running can cost me several days of
> work.
> There are of course the build bots at Bugzilla, which test other builds,
> but I am not sure if they would catch regressions. This particular case
> would be a more easy situation, but I've seen possibilities for refactoring
> in GraphicsContext stuff, which may cause not so easy to spot regressions
> if I was to go ahead do them.

Don't worry about it, just stay focused on the Haiku port. Maybe I'll
take a look at these refactoring possibilities since I have some
Linux, Windows and Mac machines I could test on. Though I too should
probably just focus on Haiku for now. With my current schedule I
barely have time to keep up with emails and Haiku, Inc. related


Other related posts: