[haiku-webkit-commits] Re: r222 - in webkit/trunk/WebCore: . platform/haiku

  • From: Stephan Assmus <superstippi@xxxxxx>
  • To: haiku-webkit-commits@xxxxxxxxxxxxx
  • Date: Thu, 25 Feb 2010 23:44:32 +0100

On 2010-02-25 at 23:38:52 [+0100], Ryan Leavengood <leavengood@xxxxxxxxx> 
wrote:
> On Thu, Feb 25, 2010 at 5:35 PM,  <webkit@xxxxxxxxxxxxxxx> wrote:
> > Author: stippi
> > Date: Thu Feb 25 22:34:59 2010
> > New Revision: 222
> > URL: http://mmlr.dyndns.org/changeset/222
> >
> > Log:
> > Implemented KURL::fileSystemPath().
> 
> I assume this file was basically copied from somewhere else? You may
> still want to include yourself in the copyright list.

Yes, it was copied accidentally from TemporaryLinkStubs. In case you 
wondered, I've read comments on Bugzilla from reviewers which encourage to 
remove copyright cruft when no code is left from the original contributor. 
Like when a file is stubbed out, it doesn't make sense to keep copyright of 
the same file from another port.

> Also it makes me
> wonder why there is not just a default implementation of this if all
> the platforms are just doing this same thing. I don't really see any
> platform-specific code here.
> 
> Maybe refactoring this could be a nice way to "give back" to WebKit.

Yes. I saw already a lot of these cleanup possibilities. The problem is 
that I have no way to test builds for other platforms. I could imagine to 
set them up, but I believe to get them running can cost me several days of 
work.

There are of course the build bots at Bugzilla, which test other builds, 
but I am not sure if they would catch regressions. This particular case 
would be a more easy situation, but I've seen possibilities for refactoring 
in GraphicsContext stuff, which may cause not so easy to spot regressions 
if I was to go ahead do them.

Best regards,
-Stephan

Other related posts: