[haiku-gsoc] Re: some questions about haiku kernel

  • From: "Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx>
  • To: haiku-gsoc@xxxxxxxxxxxxx
  • Date: Mon, 14 May 2012 12:32:01 +0200 (CEST)

On May 13, 2012 at 4:13 PM Yongcong Du <ycdu.vmcore@xxxxxxxxx> wrote:
> I have one patch to do what axel said: disable the timer for idle thread.
> And by my test, it can reduce the wake up times during idle from ~550 to
> ~320, about ~41% unnecessary wakeups. I believe this will improve the power
> efficiency when we enabled cpu idle.
>
> Looking for your comments!

Looks fine, thanks!

There is just one coding style violation: when the 'if' block is a multi-line
statement (as in case of the add_timer() call), it needs to be in its own block.
Since Fredrik already committed it, I guess its his duty to fix it, though :-)

Bye,
   Axel.

Other related posts: