Hi Jian, 2011/6/12 Jian Chiang <j.jian.chiang@xxxxxxxxx>: > This patch initialize the command ring and event ring. Next step will do No-op > test to test whether the ring setting is correct or not > > Would you please help to review it? The patch is OK. Two style issues though: add one space before and after each arithmetic operator, and avoid computing two times. fErstArea would also need a comment on what means "Erst" (it's not the german word for sure). BTW, not specific to XHCI, we need to fix the AllocateArea() call to use phys_addr_t instead of void*. B_PRIxPHYSADDR is to be used instead of %lld for dmaAddress. Bye, Jérôme