[haiku-development] Re: [patch] #1809 (BMenu not fully drawn in start window of DiskProbe)

On 2009-04-15 at 09:57:17 [+0200], Ankur Sethi <get.me.ankur@xxxxxxxxx> 
wrote:
> Fixes this ticket: http://dev.haiku-os.org/ticket/1809.
> 
> Just changed the initial UI to use the layout system instead of manual 
> layouts.

Thanks a lot! I've applied the patch in r30174 with these additional notes 
(in case you are not already subscribed to the commit notification list):

Thanks a lot! Please note some changes I have made:
* When using layout management, use the contructors that don't take BRects
  and "follow modes". (You forgot that for the BButtons.)
* You reversed the button order.
* I found it more convenient to use a BGridLayoutBuilder. And it seemed odd
  to only add the menu bar layout item, not also the label item.
* Finally, to create a patch, cd into the Haiku root folder and use "svn
  diff", like "svn diff src/apps/diskprobe/ > patch.diff". I had to apply
  your patch manually line by line, I am not very firm with "patch",
  although I am sure there would have been a way to do it... :-)

Nice work!


Best regards,
-Stephan

Other related posts: