[haiku-development] Re: media-add-on multi_audio
- From: Jérôme Duval <korli@xxxxxxxxxxxxxxxx>
- To: haiku-development@xxxxxxxxxxxxx
- Date: Sun, 22 Jan 2012 23:45:00 +0100
Hi Jérôme
2012/1/18 Jerome Leveque <leveque.jerome@xxxxxxxxx>:
> Here some patch for using multiple audio input. and changing input framerate
Some remarks:
* It seems your editor is configured for spaces instead of tabs.
* ConvFunct should be named fConversionFunc
* chan_count => channelCount, input_sample_size => inputSampleSize
* no antislash is needed except for macro. src_stride => inputStride,
dst_stride => outputStride, c => channel, chan_id => channelID
* two blank lines between methods.
* _GetConvFunct() takes in and out as parameter names: should be
inputFormat, outputFormat
* conversion methods should probably be placed in another class, see
src/add-ons/media/media-add-ons/mixer/Resampler.h for instance.
* even if they are identifers, PARAMETER_ID_IN_OUT_FREQUENCY maybe
could be treated as PARAMETER_ID_OUT_FREQUENCY |
PARAMETER_ID_IN_FREQUENCY.
I still have to check that audio drivers still work with this patch.
Bye,
Jérôme
Other related posts:
