[haiku-development] Re: [haiku-development] Commit access for Andreas Färber
- From: Ingo Weinhold <ingo_weinhold@xxxxxx>
- To: haiku-development@xxxxxxxxxxxxx
- Date: Sun, 06 Jun 2010 17:05:50 +0200
On 2010-06-06 at 15:09:18 [+0200], Stephan Assmus <superstippi@xxxxxx>
wrote:
> perhaps Ingo would be more suited to propose Andreas for commit access
> since he reviews and applies most of Andreas' patches, but to me it seems
> it would already be well deserved and review could continue via the commit
> list. Any objections?
Yes. While I'd like Andreas to get commit access eventually, I think that
time should not be now. At least not for working on the kernel.
IMO a developer should get commit access when review is not necessary
anymore, i.e. when virtually all patches are OK -- not necessarily bug
free, of course, but in a technical and "that's a good approach" sense.
Most of Andreas' non-trivial patches I've seen so far needed at least one
review+improvement iteration before I considered them OK.
I'm sure that's mainly a question of familiarity with the kernel code base
and the specific problems, so I'm optimistic that will improve. ATM I'm not
in favor of granting commit access, though.
CU, Ingo
Other related posts:
