[haiku-development] Re: Trac down, bug report here: efi_gpt.cpp has functions with wrong number of parameters

  • From: Bryce W Groff <bgroff@xxxxxxxxxx>
  • To: haiku-development@xxxxxxxxxxxxx
  • Date: Wed, 22 Jul 2009 22:08:07 -1000

First of sorry if my formating is weird, I am using an older webmail client.

> Trac is down, so I'm not creating a ticket.
> 
> Seems that ddm_modules.h was changed recently with modifications to
> the signatures of validate_create_child and create_child. As 
> such, the
> corresponding efi_gpt_validate_create_child and efi_gpt_create_child
> must be updated accordingly to account for the additional "const char
> *name" parameter.

If you have a patch and would like someone to review it, I would be more than 
happy to take a look. Most likely you have only changed the signatures and a 
review is not really needed though.

> Could someone please fix this? I added them locally and fixed up the
> call to efi_gpt_validate_create_child inside 
> efi_gpt_create_child, but
> of course the name is not used anywhere and I don't really know what's
> the code supposed to do with it. What I will do instead is watch what
> will be done to fix this so I can actually learn from it :)

With the gpt partition descriptor a partition can contain a name. This is what 
the name parameter can be used for.

> BTW, IMHO it's high time efi_gpt got added to the base image. It's
> kind of weird that Amiga partitioning scheme *is* added to the base
> image where nobody could be really using it as their system partition
> type (only foreign), whereas GPT *is* being used by Intel Mac owners
> (and me, on the non-Mac side) as their native system 
> partitioning type
> right now. So this hiccup was totally unnoticed until now that I
> rebuilt my installation after some two weeks without doing it...

+1 if it were a part of the base I would have fixed it as a part of that patch. 
Also as a Intel Mac user I would enjoy having a gpt add on. Hopefully when I 
finish work on the Intel add-on I can help work on the gpt as well.

Ciao,
Bryce

Other related posts:

  1. Home
  2. haiku-development
  3. Archive
  4. 07-2009