[haiku-development] Re: Time patch

-------- Original-Nachricht --------
> Datum: Sat, 22 Nov 2008 00:01:55 +0100
> Von: julun <host.haiku@xxxxxx>
> An: haiku-development@xxxxxxxxxxxxx
> Betreff: [haiku-development] Re: Time patch

> Hi Stephan,
> 
> Stephan Assmus schrieb:
> > Clemens zeidler wrote:
> >> this small patch adds a nice feature that the R5 Time preferences app 
> >> has: dragging the hands. Also it add keyboard input for the date and
> time 
> >> edit fields.
> >>
> >> Could somebody take a look over the patch?
> > 
> > I think the patch is good! :-) If no one beats me to it, I wanted to
> have a 
> > look at it in action and then commit it.
> 
> Good work!  :)
> 
> I just noticed some minor stuff:
> 
> The hands are not properly centered anymore. To compile it on gcc I 
> had to include stdlib.h as well. Typing an invalid date will always 
> select the first of the month in the end. I find it a bit annoying 
> while typing a year it will always switch to 2000 and up. Maybe it 
> should preserve the first part of the century.

Ups, I have read your mail after applying the patch, you have obviously tested 
it more than I did. But I guess it's an improvement in any case. I can maybe 
have a look at what you mean about the centering of the hands, if you or 
Clemens don't beat me to it.

Best regards,
-Stephan

Other related posts: