[haiku-development] Re: Terminal patch (ticket #1806)

From: "Stephan Assmus" <superstippi@xxxxxx>
To: haiku-development@xxxxxxxxxxxxx
Date: Sat, 29 Mar 2008 19:41:31 +0100

> Ok, I've made an offset on each border. It is defined to 3 pixels.

Nice patch! Thanks a lot!

Just some suggestions:

* You could rename "kOffset" to "kBorderInset", which makes it a bit
  more clear what it is IMHO.

* You could calculate it based on the font size. This just improves
  the look a bit in case you have a very high resolution screen with
  a large font size.

Best regards,
-Stephan

References:

[haiku-development] Terminal patch (ticket #1806)
From: PulkoMandy

[haiku-development] Re: Terminal patch (ticket #1806)
From: Axel Dörfler

[haiku-development] Re: Terminal patch (ticket #1806)
From: PulkoMandy

[haiku-development] Re: Terminal patch (ticket #1806)

Other related posts: