[haiku-development] Re: StyledEdit

HOST Computing wrote (2007-09-04, 12:40:56 [+0200]):
> Hi,
> 
> > "Ryan Leavengood" <leavengood@xxxxxxxxx> wrote:
> > > Now regarding the removing of the virtual keyword on several 
> > > overridden methods, I suppose this is fine since I doubt any of those 
> > > classes will ever be subclassed themselves. I'm not sure it has any 
> > > benefits though (I am no C++ expert though.)
> > 
> > Please don't do this. Carrying the virtual keyword into the subclasses 
> > just makes it clear that it's in fact a virtual overridden method - 
> > besides from the eventual warning in GCC 4 it does no good.
> > 
> > Bye,
> >    Axel.
> > 
> i agree on that, even if it does not harm either. so i will add them back 
> where needed. :)

Thanks, I like the "virtual" keywords in there as well. Helps to see what is
what quickly. I even developed the habbit of commenting sections in my 
headers for which virtuals are comming from which base class. Only makes 
sense though for more involved inheritence trees.

Best regards,
-Stephan

Other related posts: