[haiku-development] Re: Stack & Tile update

  • From: Christof Lutteroth <lutteroth@xxxxxxxxxxxxxxxxx>
  • To: "haiku-development@xxxxxxxxxxxxx" <haiku-development@xxxxxxxxxxxxx>
  • Date: Fri, 20 Nov 2009 15:00:26 +1300

Hi!

Philippe Houdoin wrote:
There are some visual artifact: the red highlighted window edge and
tab partially stay visible after stack or tile being used.
For consistency, should be using the focus highlight color instead
(default is blue), no?

Yes, it might be a good idea to reuse the focus highlight color for that.
Could anybody give some more detail about how to make a window appear in its focus highlight color? It's probably somewhere in DefaultDecorator, right?

Another question wrt. refactoring Stack&Tile: ideally the Stack&Tile code would be completely separate from the Window class in the app server (at the moment Window.cpp contains nearly all S&T code). S&T mostly needs to know about the mouse down, up and move events that are processed in

void
Window::MouseDown(BMessage* message, BPoint where, int32* _viewToken)

and

void
Window::MouseUp(BMessage* message, BPoint where, int32* _viewToken)

and

void
Window::MouseMoved(BMessage *message, BPoint where, int32* _viewToken,
        bool isLatestMouseMoved, bool isFake)


Is it possible to attach a message filter somewhere so that the S&T code does not need to touch these methods anymore but gets the relevant information directly?

Another question: in Desktop::Init(), the keyboard filter is attached that is used to detect the Windows key press for S&T:

fEventDispatcher.SetKeyboardFilter(new KeyboardFilter(this));

Is it possible to attach another keyboard filter specifically for S&T, so that we can separate the S&T code better from the existing keyboard handling code?

Cheers,
Christof

Other related posts: